Renamed reportFullDisplayed to reportFullyDisplayed #2585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deprecated old Sentry.reportFullDisplayed() method
deprecated old Sentry.reportFullDisplayed() method
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7c199d8 | 323.18 ms | 391.33 ms | 68.15 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7c199d8 | 1.73 MiB | 2.34 MiB | 626.23 KiB |
Previous results on branch: fix/rename-full-displayed
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 9129a4b | 318.52 ms | 355.42 ms | 36.90 ms |
| d20ef6a | 354.69 ms | 421.38 ms | 66.69 ms |
| 7ad99f4 | 350.50 ms | 405.67 ms | 55.17 ms |
| 32b5573 | 323.83 ms | 340.88 ms | 17.05 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 9129a4b | 1.73 MiB | 2.34 MiB | 626.25 KiB |
| d20ef6a | 1.73 MiB | 2.34 MiB | 626.25 KiB |
| 7ad99f4 | 1.73 MiB | 2.34 MiB | 626.25 KiB |
| 32b5573 | 1.73 MiB | 2.34 MiB | 626.25 KiB |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2585 +/- ##
============================================
+ Coverage 80.42% 80.47% +0.04%
- Complexity 4027 4032 +5
============================================
Files 333 333
Lines 15189 15193 +4
Branches 1979 1979
============================================
+ Hits 12216 12226 +10
+ Misses 2194 2188 -6
Partials 779 779
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
markushi
reviewed
Mar 6, 2023
romtsn
reviewed
Mar 6, 2023
romtsn
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Rename all occurrences of FullDisplayed with FullyDisplayed
Deprecated old Sentry.reportFullDisplayed() method
💡 Motivation and Context
reportFullDisplayed is not correct english
It fixes #2575
💚 How did you test it?
Unit tests
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps